Skip to content

Commit

Permalink
staging: xgifb: eliminate filter_tb global variable
Browse files Browse the repository at this point in the history
filter_tb is only used inside a single function, and it does not need
to be static.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Aaro Koskinen authored and Greg Kroah-Hartman committed Oct 12, 2011
1 parent c11d0ef commit 84a6c46
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/staging/xgifb/XGI_main.h
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,5 @@ static const struct _XGI_TV_filter {
};

static int filter = -1;
static unsigned char filter_tb;

#endif
3 changes: 3 additions & 0 deletions drivers/staging/xgifb/XGI_main_26.c
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,8 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
reg = xgifb_reg_get(XGIPART4, 0x01);

if (reg < 0xB0) { /* Set filter for XGI301 */
int filter_tb;

switch (xgifb_info->video_width) {
case 320:
filter_tb = (xgifb_info->TV_type ==
Expand All @@ -964,6 +966,7 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
TVMODE_NTSC) ? 7 : 15;
break;
default:
filter_tb = 0;
filter = -1;
break;
}
Expand Down

0 comments on commit 84a6c46

Please sign in to comment.