Skip to content

Commit

Permalink
ACPI: call acpi_debug_init() explicitly rather than as initcall
Browse files Browse the repository at this point in the history
This patch makes acpi_init() call acpi_debug_init() directly.
Previously, both were subsys_initcalls.  acpi_debug_init()
must happen after acpi_init(), and it's better to call it
explicitly rather than rely on link ordering.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Mar 27, 2009
1 parent 141a0af commit 84f810c
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
1 change: 1 addition & 0 deletions drivers/acpi/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ static int __init acpi_init(void)
acpi_ec_init();
acpi_power_init();
acpi_system_init();
acpi_debug_init();
return result;
}

Expand Down
14 changes: 6 additions & 8 deletions drivers/acpi/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -297,17 +297,15 @@ acpi_system_write_debug(struct file *file,

return count;
}
#endif

static int __init acpi_debug_init(void)
int __init acpi_debug_init(void)
{
#ifdef CONFIG_ACPI_PROCFS
struct proc_dir_entry *entry;
int error = 0;
char *name;


if (acpi_disabled)
return 0;

/* 'debug_layer' [R/W] */
name = ACPI_SYSTEM_FILE_DEBUG_LAYER;
entry =
Expand Down Expand Up @@ -338,7 +336,7 @@ static int __init acpi_debug_init(void)
remove_proc_entry(ACPI_SYSTEM_FILE_DEBUG_LAYER, acpi_root_dir);
error = -ENODEV;
goto Done;
}

subsys_initcall(acpi_debug_init);
#else
return 0;
#endif
}
6 changes: 6 additions & 0 deletions drivers/acpi/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
int acpi_scan_init(void);
int acpi_system_init(void);

#ifdef CONFIG_ACPI_DEBUG
int acpi_debug_init(void);
#else
static inline int acpi_debug_init(void) { return 0; }
#endif

/* --------------------------------------------------------------------------
Power Resource
-------------------------------------------------------------------------- */
Expand Down

0 comments on commit 84f810c

Please sign in to comment.