Skip to content

Commit

Permalink
[NET_SCHED]: sch_ingress: remove useless printk
Browse files Browse the repository at this point in the history
The printk about ingress qdisc registration error can't be triggered
under normal circumstances. Since register_qdisc only fails for two
identical registrations, the only way to trigger it is by loading the
sch_ingress modules multiple times under different names, in which
case we already return -EEXIST to userspace.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jan 28, 2008
1 parent 1389356 commit 8916876
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions net/sched/sch_ingress.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,7 @@ static struct Qdisc_ops ingress_qdisc_ops __read_mostly = {

static int __init ingress_module_init(void)
{
int ret = 0;

if ((ret = register_qdisc(&ingress_qdisc_ops)) < 0) {
printk("Unable to register Ingress qdisc\n");
return ret;
}

return ret;
return register_qdisc(&ingress_qdisc_ops);
}

static void __exit ingress_module_exit(void)
Expand Down

0 comments on commit 8916876

Please sign in to comment.