Skip to content

Commit

Permalink
block/compat_ioctl.c: do not leak info to user-space
Browse files Browse the repository at this point in the history
There is a hole in struct hd_geometry, so we have to zero the struct on
stack before copying it to user-space.

Signed-off-by: Cong Wang <amwang@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Cong Wang authored and Linus Torvalds committed Jul 3, 2013
1 parent 31bd8fb commit 8b0d77f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions block/compat_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ static int compat_hdio_getgeo(struct gendisk *disk, struct block_device *bdev,
if (!disk->fops->getgeo)
return -ENOTTY;

memset(&geo, 0, sizeof(geo));
/*
* We need to set the startsect first, the driver may
* want to override it.
Expand Down

0 comments on commit 8b0d77f

Please sign in to comment.