Skip to content

Commit

Permalink
pinctrl/lantiq: the pinconf OD parameter argument was ignored
Browse files Browse the repository at this point in the history
When setting the OpenDrain bit we should really honour the
argument passed inside the devicetree.

Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
John Crispin authored and Linus Walleij committed Feb 5, 2013
1 parent 6360350 commit 9338628
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/pinctrl/pinctrl-xway.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,10 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
reg = GPIO3_OD;
else
reg = GPIO_OD(pin);
gpio_setbit(info->membase[0], reg, PORT_PIN(pin));
if (arg == 0)
gpio_setbit(info->membase[0], reg, PORT_PIN(pin));
else
gpio_clearbit(info->membase[0], reg, PORT_PIN(pin));
break;

case LTQ_PINCONF_PARAM_PULL:
Expand Down

0 comments on commit 9338628

Please sign in to comment.