Skip to content

Commit

Permalink
drm/i915: Don't pin the status page as mappable
Browse files Browse the repository at this point in the history
We access it through the cpu window. No functional difference expected
atm since we default to a bottom-up allocation scheme. But that might
eventually change so that we prefer the unmappable range for buffers
that don't need cpu gtt access.

Split out from Chris vma-bind rework.

Note that this is only possible due to the split-up of the mappable
pin flag into PIN_GLOBAL and PIN_MAPPABLE.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Feb 14, 2014
1 parent be1fa12 commit 9a6bbb6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_ringbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1275,7 +1275,7 @@ static int init_status_page(struct intel_ring_buffer *ring)

i915_gem_object_set_cache_level(obj, I915_CACHE_LLC);

ret = i915_gem_obj_ggtt_pin(obj, 4096, PIN_MAPPABLE);
ret = i915_gem_obj_ggtt_pin(obj, 4096, 0);
if (ret)
goto err_unref;

Expand Down

0 comments on commit 9a6bbb6

Please sign in to comment.