Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 318071
b: refs/heads/master
c: c2eb50b
h: refs/heads/master
i:
  318069: 10daea1
  318067: e186ab8
  318063: 2f75be9
v: v3
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent 7ad44b9 commit 9bb649f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2329a10c3f985cbe7bba6ff3a053837f71a1ea40
refs/heads/master: c2eb50bbdb4400fae3d462237470c22e0f98545b
25 changes: 12 additions & 13 deletions trunk/drivers/staging/comedi/drivers/cb_pcidio.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ static const struct pcidio_board pcidio_boards[] = {
struct pcidio_private {
int data; /* currently unused */

/* would be useful for a PCI device */
struct pci_dev *pci_dev;

/* used for DO readback, currently unused */
unsigned int do_readback[4]; /* up to 4 unsigned int suffice to hold 96 bits for PCI-DIO96 */

Expand Down Expand Up @@ -143,6 +140,7 @@ static struct pci_dev *pcidio_find_pci_dev(struct comedi_device *dev,

static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{
struct pci_dev *pcidev;
int i;
int ret;

Expand All @@ -153,22 +151,23 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (alloc_private(dev, sizeof(struct pcidio_private)) < 0)
return -ENOMEM;

devpriv->pci_dev = pcidio_find_pci_dev(dev, it);
if (!devpriv->pci_dev)
pcidev = pcidio_find_pci_dev(dev, it);
if (!pcidev)
return -EIO;
comedi_set_hw_dev(dev, &pcidev->dev);

/*
* Initialize dev->board_name. Note that we can use the "thisboard"
* macro now, since we just initialized it in the last line.
*/
dev->board_name = thisboard->name;

if (comedi_pci_enable(devpriv->pci_dev, thisboard->name))
if (comedi_pci_enable(pcidev, thisboard->name))
return -EIO;

devpriv->dio_reg_base
=
pci_resource_start(devpriv->pci_dev, thisboard->dioregs_badrindex);
pci_resource_start(pcidev, thisboard->dioregs_badrindex);

ret = comedi_alloc_subdevices(dev, thisboard->n_8255);
if (ret)
Expand All @@ -186,12 +185,12 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)

static void pcidio_detach(struct comedi_device *dev)
{
if (devpriv) {
if (devpriv->pci_dev) {
if (devpriv->dio_reg_base)
comedi_pci_disable(devpriv->pci_dev);
pci_dev_put(devpriv->pci_dev);
}
struct pci_dev *pcidev = comedi_to_pci_dev(dev);

if (pcidev) {
if (devpriv->dio_reg_base)
comedi_pci_disable(pcidev);
pci_dev_put(pcidev);
}
if (dev->subdevices) {
int i;
Expand Down

0 comments on commit 9bb649f

Please sign in to comment.