Skip to content

Commit

Permalink
perf tools: Check existence of _get_comp_words_by_ref when bash compl…
Browse files Browse the repository at this point in the history
…eting

The '_get_comp_words_by_ref' function is available from the bash
completion v1.2 so that earlier version emits following warning:

  $ perf re<TAB>_get_comp_words_by_ref: command not found

Use older '_get_cword' method when the above function doesn't exist.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1349191294-6926-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Namhyung Kim authored and Arnaldo Carvalho de Melo committed Oct 2, 2012
1 parent 002439e commit a1d668c
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions tools/perf/bash_completion
Original file line number Diff line number Diff line change
@@ -1,12 +1,23 @@
# perf completion

function_exists()
{
declare -F $1 > /dev/null
return $?
}

have perf &&
_perf()
{
local cur cmd
local cur prev cmd

COMPREPLY=()
_get_comp_words_by_ref cur prev
if function_exists _get_comp_words_by_ref; then
_get_comp_words_by_ref cur prev
else
cur=$(_get_cword)
prev=${COMP_WORDS[COMP_CWORD-1]}
fi

cmd=${COMP_WORDS[0]}

Expand Down

0 comments on commit a1d668c

Please sign in to comment.