Skip to content

Commit

Permalink
mfd: Fix incorrect kfree(i2c) in wm831x-core i2c_driver probe
Browse files Browse the repository at this point in the history
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Axel Lin authored and Samuel Ortiz committed Aug 12, 2010
1 parent 04a0642 commit a2cddb6
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/mfd/wm831x-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1757,10 +1757,8 @@ static int wm831x_i2c_probe(struct i2c_client *i2c,
struct wm831x *wm831x;

wm831x = kzalloc(sizeof(struct wm831x), GFP_KERNEL);
if (wm831x == NULL) {
kfree(i2c);
if (wm831x == NULL)
return -ENOMEM;
}

i2c_set_clientdata(i2c, wm831x);
wm831x->dev = &i2c->dev;
Expand Down

0 comments on commit a2cddb6

Please sign in to comment.