Skip to content

Commit

Permalink
staging:iio:adt7310: Do not return error code in interrupt handler
Browse files Browse the repository at this point in the history
The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Jonathan Cameron committed Jul 8, 2012
1 parent abad65c commit a4eef30
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/staging/iio/adc/adt7310.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ static irqreturn_t adt7310_event_handler(int irq, void *private)

ret = adt7310_spi_read_byte(chip, ADT7310_STATUS, &status);
if (ret)
return ret;
goto done;

if (status & ADT7310_STAT_T_HIGH)
iio_push_event(indio_dev,
Expand All @@ -417,6 +417,8 @@ static irqreturn_t adt7310_event_handler(int irq, void *private)
IIO_EV_TYPE_THRESH,
IIO_EV_DIR_RISING),
timestamp);

done:
return IRQ_HANDLED;
}

Expand Down

0 comments on commit a4eef30

Please sign in to comment.