Skip to content

Commit

Permalink
drivers/video/fbmem.c: simplify strlen()==0 check in fb_get_options()
Browse files Browse the repository at this point in the history
Replaced !strlen(str) check with !str[0].  Removed the variable which was
used solely to store strlen result.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Denys Vlasenko authored and Linus Torvalds committed Aug 11, 2010
1 parent 26c5be3 commit a67ef27
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/video/fbmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -1786,7 +1786,7 @@ static int ofonly __read_mostly;
int fb_get_options(char *name, char **option)
{
char *opt, *options = NULL;
int opt_len, retval = 0;
int retval = 0;
int name_len = strlen(name), i;

if (name_len && ofonly && strncmp(name, "offb", 4))
Expand All @@ -1796,8 +1796,7 @@ int fb_get_options(char *name, char **option)
for (i = 0; i < FB_MAX; i++) {
if (video_options[i] == NULL)
continue;
opt_len = strlen(video_options[i]);
if (!opt_len)
if (!video_options[i][0])
continue;
opt = video_options[i];
if (!strncmp(name, opt, name_len) &&
Expand Down

0 comments on commit a67ef27

Please sign in to comment.