Skip to content

Commit

Permalink
[SCSI] fcoe: libfcoe: extra semicolon in CHECK_LOGGING macros causes …
Browse files Browse the repository at this point in the history
…compile error

If using code like this:
	if (foo)
		FCOE_DBG("foo\n);
	else
		FCOE_DBG("bar\n");

one gets compile errors because FCOE_DBG expands with its own semicolon,
making one too many for the if-statement.

Remove the offending semicolon in fcoe.h and also a similar case
in libfcoe.c.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
Joe Eykholt authored and James Bottomley committed Sep 5, 2009
1 parent cd305ce commit a69b06b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/scsi/fcoe/fcoe.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ do { \
do { \
CMD; \
} while (0); \
} while (0);
} while (0)

#define FCOE_DBG(fmt, args...) \
FCOE_CHECK_LOGGING(FCOE_LOGGING, \
Expand Down
2 changes: 1 addition & 1 deletion drivers/scsi/fcoe/libfcoe.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ do { \
do { \
CMD; \
} while (0); \
} while (0);
} while (0)

#define LIBFCOE_DBG(fmt, args...) \
LIBFCOE_CHECK_LOGGING(LIBFCOE_LOGGING, \
Expand Down

0 comments on commit a69b06b

Please sign in to comment.