Skip to content

Commit

Permalink
[media] drivers/media/rc/ati_remote.c: fix error return code
Browse files Browse the repository at this point in the history
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Peter Senna Tschudin authored and Mauro Carvalho Chehab committed Sep 23, 2012
1 parent 6ea7cf7 commit a84b17e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/media/rc/ati_remote.c
Original file line number Diff line number Diff line change
Expand Up @@ -937,8 +937,10 @@ static int ati_remote_probe(struct usb_interface *interface,
/* Set up and register mouse input device */
if (mouse) {
input_dev = input_allocate_device();
if (!input_dev)
if (!input_dev) {
err = -ENOMEM;
goto fail4;
}

ati_remote->idev = input_dev;
ati_remote_input_init(ati_remote);
Expand Down

0 comments on commit a84b17e

Please sign in to comment.