Skip to content

Commit

Permalink
dynamic_debug: pr_err() call should not depend upon verbosity
Browse files Browse the repository at this point in the history
Issue keyword/parsing errors even w/o verbose set;
uncover otherwize mysterious non-functionality.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jim Cromie authored and Greg Kroah-Hartman committed Jan 24, 2012
1 parent bc757f6 commit ae27f86
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/dynamic_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,7 @@ static int ddebug_parse_query(char *words[], int nwords,
query->last_lineno = query->first_lineno;
}
} else {
if (verbose)
pr_err("unknown keyword \"%s\"\n", words[i]);
pr_err("unknown keyword \"%s\"\n", words[i]);
return -EINVAL;
}
}
Expand Down

0 comments on commit ae27f86

Please sign in to comment.