Skip to content

Commit

Permalink
Merge branch 'we21-fix' of git://git.kernel.org/pub/scm/linux/kernel/…
Browse files Browse the repository at this point in the history
…git/linville/wireless-2.6 into tmp
  • Loading branch information
Jeff Garzik committed Oct 21, 2006
2 parents 18a8e86 + 98978ed commit af60496
Showing 1 changed file with 32 additions and 1 deletion.
33 changes: 32 additions & 1 deletion net/core/wireless.c
Original file line number Diff line number Diff line change
Expand Up @@ -748,11 +748,39 @@ static int ioctl_standard_call(struct net_device * dev,
int extra_size;
int user_length = 0;
int err;
int essid_compat = 0;

/* Calculate space needed by arguments. Always allocate
* for max space. Easier, and won't last long... */
extra_size = descr->max_tokens * descr->token_size;

/* Check need for ESSID compatibility for WE < 21 */
switch (cmd) {
case SIOCSIWESSID:
case SIOCGIWESSID:
case SIOCSIWNICKN:
case SIOCGIWNICKN:
if (iwr->u.data.length == descr->max_tokens + 1)
essid_compat = 1;
else if (IW_IS_SET(cmd) && (iwr->u.data.length != 0)) {
char essid[IW_ESSID_MAX_SIZE + 1];

err = copy_from_user(essid, iwr->u.data.pointer,
iwr->u.data.length *
descr->token_size);
if (err)
return -EFAULT;

if (essid[iwr->u.data.length - 1] == '\0')
essid_compat = 1;
}
break;
default:
break;
}

iwr->u.data.length -= essid_compat;

/* Check what user space is giving us */
if(IW_IS_SET(cmd)) {
/* Check NULL pointer */
Expand Down Expand Up @@ -795,7 +823,8 @@ static int ioctl_standard_call(struct net_device * dev,
#endif /* WE_IOCTL_DEBUG */

/* Create the kernel buffer */
extra = kmalloc(extra_size, GFP_KERNEL);
/* kzalloc ensures NULL-termination for essid_compat */
extra = kzalloc(extra_size, GFP_KERNEL);
if (extra == NULL) {
return -ENOMEM;
}
Expand All @@ -819,6 +848,8 @@ static int ioctl_standard_call(struct net_device * dev,
/* Call the handler */
ret = handler(dev, &info, &(iwr->u), extra);

iwr->u.data.length += essid_compat;

/* If we have something to return to the user */
if (!ret && IW_IS_GET(cmd)) {
/* Check if there is enough buffer up there */
Expand Down

0 comments on commit af60496

Please sign in to comment.