Skip to content

Commit

Permalink
gianfar: Use kmemdup rather than duplicating its implementation
Browse files Browse the repository at this point in the history
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thomas Meyer authored and David S. Miller committed Nov 21, 2011
1 parent 65d9d2c commit b8ffdbd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/freescale/gianfar_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -1410,10 +1410,9 @@ static int gfar_optimize_filer_masks(struct filer_table *tab)

/* We need a copy of the filer table because
* we want to change its order */
temp_table = kmalloc(sizeof(*temp_table), GFP_KERNEL);
temp_table = kmemdup(tab, sizeof(*temp_table), GFP_KERNEL);
if (temp_table == NULL)
return -ENOMEM;
memcpy(temp_table, tab, sizeof(*temp_table));

mask_table = kcalloc(MAX_FILER_CACHE_IDX / 2 + 1,
sizeof(struct gfar_mask_entry), GFP_KERNEL);
Expand Down

0 comments on commit b8ffdbd

Please sign in to comment.