Skip to content

Commit

Permalink
perf: Clean up trivial style issues in builtin-help.c
Browse files Browse the repository at this point in the history
Pointed out by checkpatch.

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Cc: a.p.zijlstra@chello.nl
Cc: paulus@samba.org
Cc: Valdis.Kletnieks@vt.edu
LKML-Reference: <1257254925-5423-1-git-send-email-tfransosi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Thiago Farina authored and Ingo Molnar committed Nov 3, 2009
1 parent 900b20d commit c1e5301
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions tools/perf/builtin-help.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ static const char *get_man_viewer_info(const char *name)
{
struct man_viewer_info_list *viewer;

for (viewer = man_viewer_info_list; viewer; viewer = viewer->next)
{
for (viewer = man_viewer_info_list; viewer; viewer = viewer->next) {
if (!strcasecmp(name, viewer->name))
return viewer->info;
}
Expand Down Expand Up @@ -115,7 +114,7 @@ static int check_emacsclient_version(void)
return 0;
}

static void exec_woman_emacs(const char* path, const char *page)
static void exec_woman_emacs(const char *path, const char *page)
{
if (!check_emacsclient_version()) {
/* This works only with emacsclient version >= 22. */
Expand All @@ -129,7 +128,7 @@ static void exec_woman_emacs(const char* path, const char *page)
}
}

static void exec_man_konqueror(const char* path, const char *page)
static void exec_man_konqueror(const char *path, const char *page)
{
const char *display = getenv("DISPLAY");
if (display && *display) {
Expand Down Expand Up @@ -157,7 +156,7 @@ static void exec_man_konqueror(const char* path, const char *page)
}
}

static void exec_man_man(const char* path, const char *page)
static void exec_man_man(const char *path, const char *page)
{
if (!path)
path = "man";
Expand Down Expand Up @@ -364,9 +363,8 @@ static void show_man_page(const char *perf_cmd)

setup_man_path();
for (viewer = man_viewer_list; viewer; viewer = viewer->next)
{
exec_viewer(viewer->name, page); /* will return when unable */
}

if (fallback)
exec_viewer(fallback, page);
exec_viewer("man", page);
Expand Down

0 comments on commit c1e5301

Please sign in to comment.