Skip to content

Commit

Permalink
NFC: Move the pn544_hci dereference below the NULL test
Browse files Browse the repository at this point in the history
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Wei Yongjun authored and Samuel Ortiz committed Sep 24, 2012
1 parent d6650a2 commit c51ad34
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/nfc/pn544_hci.c
Original file line number Diff line number Diff line change
Expand Up @@ -346,13 +346,16 @@ static int pn544_hci_i2c_read(struct i2c_client *client, struct sk_buff **skb)
static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id)
{
struct pn544_hci_info *info = dev_id;
struct i2c_client *client = info->i2c_dev;
struct i2c_client *client;
struct sk_buff *skb = NULL;
int r;

BUG_ON(!info);
BUG_ON(irq != info->i2c_dev->irq);
if (!info || irq != info->i2c_dev->irq) {
WARN_ON_ONCE(1);
return IRQ_NONE;
}

client = info->i2c_dev;
dev_dbg(&client->dev, "IRQ\n");

if (info->hard_fault != 0)
Expand Down

0 comments on commit c51ad34

Please sign in to comment.