Skip to content

Commit

Permalink
jbd: abort when failed to log metadata buffers
Browse files Browse the repository at this point in the history
If we failed to write metadata buffers to the journal space and succeeded
to write the commit record, stale data can be written back to the
filesystem as metadata in the recovery phase.

To avoid this, when we failed to write out metadata buffers, abort the
journal before writing the commit record.

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Hidehiro Kawai authored and Linus Torvalds committed Oct 20, 2008
1 parent 60c11d2 commit d1645e5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/jbd/commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,9 @@ void journal_commit_transaction(journal_t *journal)
/* AKPM: bforget here */
}

if (err)
journal_abort(journal, err);

jbd_debug(3, "JBD: commit phase 6\n");

if (journal_write_commit_record(journal, commit_transaction))
Expand Down

0 comments on commit d1645e5

Please sign in to comment.