Skip to content

Commit

Permalink
dynamic_debug: drop explicit !=NULL checks
Browse files Browse the repository at this point in the history
Convert 'if (x !=NULL)' checks into 'if (x)'.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jim Cromie authored and Greg Kroah-Hartman committed Jan 24, 2012
1 parent ae27f86 commit d6a238d
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions lib/dynamic_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,27 +115,26 @@ static void ddebug_change(const struct ddebug_query *query,
list_for_each_entry(dt, &ddebug_tables, link) {

/* match against the module name */
if (query->module != NULL &&
strcmp(query->module, dt->mod_name))
if (query->module && strcmp(query->module, dt->mod_name))
continue;

for (i = 0 ; i < dt->num_ddebugs ; i++) {
struct _ddebug *dp = &dt->ddebugs[i];

/* match against the source filename */
if (query->filename != NULL &&
if (query->filename &&
strcmp(query->filename, dp->filename) &&
strcmp(query->filename, basename(dp->filename)))
continue;

/* match against the function */
if (query->function != NULL &&
if (query->function &&
strcmp(query->function, dp->function))
continue;

/* match against the format */
if (query->format != NULL &&
strstr(dp->format, query->format) == NULL)
if (query->format &&
!strstr(dp->format, query->format))
continue;

/* match against the line number range */
Expand Down

0 comments on commit d6a238d

Please sign in to comment.