Skip to content

Commit

Permalink
lcs: Recognize return codes of ccw_device_set_online().
Browse files Browse the repository at this point in the history
The creation of a new lcs device requires a call to the function
ccw_device_set_online() for the read and the write channel. Failure
of either call should terminate the lcs device creation immediately
with return code -ENODEV.

Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Klaus-Dieter Wacker authored and David S. Miller committed Oct 18, 2009
1 parent d62e09e commit d816d42
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions drivers/s390/net/lcs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2130,8 +2130,12 @@ lcs_new_device(struct ccwgroup_device *ccwgdev)
card->write.ccwdev = ccwgdev->cdev[1];

recover_state = card->state;
ccw_device_set_online(card->read.ccwdev);
ccw_device_set_online(card->write.ccwdev);
rc = ccw_device_set_online(card->read.ccwdev);
if (rc)
goto out_err;
rc = ccw_device_set_online(card->write.ccwdev);
if (rc)
goto out_werr;

LCS_DBF_TEXT(3, setup, "lcsnewdv");

Expand Down Expand Up @@ -2210,8 +2214,10 @@ lcs_new_device(struct ccwgroup_device *ccwgdev)
return 0;
out:

ccw_device_set_offline(card->read.ccwdev);
ccw_device_set_offline(card->write.ccwdev);
out_werr:
ccw_device_set_offline(card->read.ccwdev);
out_err:
return -ENODEV;
}

Expand Down

0 comments on commit d816d42

Please sign in to comment.