Skip to content

Commit

Permalink
Merge trivial low-risk suspend hotkey bugzilla-5918 into release
Browse files Browse the repository at this point in the history
  • Loading branch information
Len Brown committed Aug 21, 2006
6 parents ef7d1b2 + 5b9c9bf + df6fd31 + 4e6e650 + 5672bde + 16a7474 commit da547d7
Show file tree
Hide file tree
Showing 16 changed files with 229 additions and 179 deletions.
6 changes: 6 additions & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,12 @@ M: rdunlap@xenotime.net
T: git http://tali.admingilde.org/git/linux-docbook.git
S: Maintained

DOCKING STATION DRIVER
P: Kristen Carlson Accardi
M: kristen.c.accardi@intel.com
L: linux-acpi@vger.kernel.org
S: Maintained

DOUBLETALK DRIVER
P: James R. Van Zandt
M: jrv@vanzandt.mv.com
Expand Down
2 changes: 1 addition & 1 deletion arch/i386/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ static inline int gsi_irq_sharing(int gsi) { return gsi; }

#define BAD_MADT_ENTRY(entry, end) ( \
(!entry) || (unsigned long)entry + sizeof(*entry) > end || \
((acpi_table_entry_header *)entry)->length != sizeof(*entry))
((acpi_table_entry_header *)entry)->length < sizeof(*entry))

#define PREFIX "ACPI: "

Expand Down
5 changes: 4 additions & 1 deletion arch/i386/kernel/acpi/wakeup.S
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,10 @@ ENTRY(do_suspend_lowlevel)
pushl $3
call acpi_enter_sleep_state
addl $4, %esp
ret

# In case of S3 failure, we'll emerge here. Jump
# to ret_point to recover
jmp ret_point
.p2align 4,,7
ret_point:
call restore_registers
Expand Down
2 changes: 1 addition & 1 deletion arch/ia64/kernel/acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@

#define BAD_MADT_ENTRY(entry, end) ( \
(!entry) || (unsigned long)entry + sizeof(*entry) > end || \
((acpi_table_entry_header *)entry)->length != sizeof(*entry))
((acpi_table_entry_header *)entry)->length < sizeof(*entry))

#define PREFIX "ACPI: "

Expand Down
2 changes: 2 additions & 0 deletions drivers/acpi/ac.c
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,8 @@ static int __init acpi_ac_init(void)
{
int result;

if (acpi_disabled)
return -ENODEV;

acpi_ac_dir = acpi_lock_ac_dir();
if (!acpi_ac_dir)
Expand Down
8 changes: 2 additions & 6 deletions drivers/acpi/acpi_memhotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -484,10 +484,8 @@ acpi_memory_register_notify_handler(acpi_handle handle,


status = is_memory_device(handle);
if (ACPI_FAILURE(status)){
ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
if (ACPI_FAILURE(status))
return AE_OK; /* continue */
}

status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
acpi_memory_device_notify, NULL);
Expand All @@ -503,10 +501,8 @@ acpi_memory_deregister_notify_handler(acpi_handle handle,


status = is_memory_device(handle);
if (ACPI_FAILURE(status)){
ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
if (ACPI_FAILURE(status))
return AE_OK; /* continue */
}

status = acpi_remove_notify_handler(handle,
ACPI_SYSTEM_NOTIFY,
Expand Down
3 changes: 3 additions & 0 deletions drivers/acpi/battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,9 @@ static int __init acpi_battery_init(void)
{
int result;

if (acpi_disabled)
return -ENODEV;

acpi_battery_dir = acpi_lock_battery_dir();
if (!acpi_battery_dir)
return -ENODEV;
Expand Down
11 changes: 8 additions & 3 deletions drivers/acpi/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/ioport.h>
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/sched.h>
#include <linux/pm.h>
Expand Down Expand Up @@ -68,7 +69,8 @@ int acpi_bus_get_device(acpi_handle handle, struct acpi_device **device)

status = acpi_get_data(handle, acpi_bus_data_handler, (void **)device);
if (ACPI_FAILURE(status) || !*device) {
ACPI_EXCEPTION((AE_INFO, status, "No context for object [%p]", handle));
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No context for object [%p]\n",
handle));
return -ENODEV;
}

Expand Down Expand Up @@ -192,7 +194,7 @@ int acpi_bus_set_power(acpi_handle handle, int state)
/* Make sure this is a valid target state */

if (!device->flags.power_manageable) {
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device `[%s]' is not power manageable",
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device `[%s]' is not power manageable\n",
device->kobj.name));
return -ENODEV;
}
Expand Down Expand Up @@ -738,7 +740,10 @@ static int __init acpi_init(void)
return -ENODEV;
}

firmware_register(&acpi_subsys);
result = firmware_register(&acpi_subsys);
if (result < 0)
printk(KERN_WARNING "%s: firmware_register error: %d\n",
__FUNCTION__, result);

result = acpi_bus_init();

Expand Down
Loading

0 comments on commit da547d7

Please sign in to comment.