Skip to content

Commit

Permalink
staging: comedi: adv_pci1723: store the pci_dev in the comedi_device
Browse files Browse the repository at this point in the history
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent cc04c8a commit dbe85f1
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions drivers/staging/comedi/drivers/adv_pci1723.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ static const struct pci1723_board boardtypes[] = {
struct pci1723_private {
int valid; /* card is usable; */

struct pci_dev *pcidev;
unsigned char da_range[8]; /* D/A output range for each channel */

short ao_data[8]; /* data output buffer */
Expand Down Expand Up @@ -315,6 +314,7 @@ static struct pci_dev *pci1723_find_pci_dev(struct comedi_device *dev,
static int pci1723_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
struct pci_dev *pcidev;
struct comedi_subdevice *s;
int ret, subdev, n_subdevices;

Expand All @@ -327,15 +327,16 @@ static int pci1723_attach(struct comedi_device *dev,
return -ENOMEM;
}

devpriv->pcidev = pci1723_find_pci_dev(dev, it);
if (!devpriv->pcidev)
pcidev = pci1723_find_pci_dev(dev, it);
if (!pcidev)
return -EIO;
comedi_set_hw_dev(dev, &pcidev->dev);

ret = comedi_pci_enable(devpriv->pcidev, "adv_pci1723");
ret = comedi_pci_enable(pcidev, "adv_pci1723");
if (ret)
return ret;

dev->iobase = pci_resource_start(devpriv->pcidev, 2);
dev->iobase = pci_resource_start(pcidev, 2);

dev->board_name = this_board->name;

Expand Down Expand Up @@ -410,14 +411,16 @@ static int pci1723_attach(struct comedi_device *dev,

static void pci1723_detach(struct comedi_device *dev)
{
struct pci_dev *pcidev = comedi_to_pci_dev(dev);

if (dev->private) {
if (devpriv->valid)
pci1723_reset(dev);
if (devpriv->pcidev) {
if (dev->iobase)
comedi_pci_disable(devpriv->pcidev);
pci_dev_put(devpriv->pcidev);
}
}
if (pcidev) {
if (dev->iobase)
comedi_pci_disable(pcidev);
pci_dev_put(pcidev);
}
}

Expand Down

0 comments on commit dbe85f1

Please sign in to comment.