Skip to content

Commit

Permalink
ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put
Browse files Browse the repository at this point in the history
It is possible for the timer handlers to run after the call to
ip_mc_down so use in_dev_put instead of __in_dev_put in the handler
function in order to do proper cleanup when the refcnt reaches 0.
Otherwise, the refcnt can reach zero without the in_device being
destroyed and we end up leaking a reference to the net_device and
see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Salam Noureddine authored and David S. Miller committed Oct 1, 2013
1 parent 437a3ae commit e240165
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/ipv4/igmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ static void igmp_gq_timer_expire(unsigned long data)

in_dev->mr_gq_running = 0;
igmpv3_send_report(in_dev, NULL);
__in_dev_put(in_dev);
in_dev_put(in_dev);
}

static void igmp_ifc_timer_expire(unsigned long data)
Expand All @@ -749,7 +749,7 @@ static void igmp_ifc_timer_expire(unsigned long data)
igmp_ifc_start_timer(in_dev,
unsolicited_report_interval(in_dev));
}
__in_dev_put(in_dev);
in_dev_put(in_dev);
}

static void igmp_ifc_event(struct in_device *in_dev)
Expand Down

0 comments on commit e240165

Please sign in to comment.