---

yaml --- r: 325599 b: refs/heads/master c: 0a44ab4 h: refs/heads/master i: 325597: a8fa54c 325595: b2de3c2 325591: cf939c2 325583: 7a2e34a 325567: cf75ad9 v: v3
git-mirror · Jun 27, 2012 · ed92331 · ed92331
1 parent 61496a3
commit ed92331
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: fc915c8b930c3114f2a838f7e2cd8789ad6fedc3
+refs/heads/master: 0a44ab41eb833d07e3ec807d87151c7164d4f075
diff --git a/trunk/drivers/tty/n_tty.c b/trunk/drivers/tty/n_tty.c
@@ -1432,6 +1432,12 @@ static void n_tty_receive_buf(struct tty_struct *tty, const unsigned char *cp,
 	 */
 	if (tty->receive_room < TTY_THRESHOLD_THROTTLE)
 		tty_throttle(tty);
+
+        /* FIXME: there is a tiny race here if the receive room check runs
+           before the other work executes and empties the buffer (upping
+           the receiving room and unthrottling. We then throttle and get
+           stuck. This has been observed and traced down by Vincent Pillet/
+           We need to address this when we sort out out the rx path locking */
 }
 
 int is_ignored(int sig)