Skip to content

Commit

Permalink
drivers/net/hamradio: Move a dereference below a NULL test
Browse files Browse the repository at this point in the history
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Dec 16, 2008
1 parent f162e97 commit f40e063
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/hamradio/mkiss.c
Original file line number Diff line number Diff line change
Expand Up @@ -846,12 +846,13 @@ static int mkiss_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd, unsigned long arg)
{
struct mkiss *ax = mkiss_get(tty);
struct net_device *dev = ax->dev;
struct net_device *dev;
unsigned int tmp, err;

/* First make sure we're connected. */
if (ax == NULL)
return -ENXIO;
dev = ax->dev;

switch (cmd) {
case SIOCGIFNAME:
Expand Down

0 comments on commit f40e063

Please sign in to comment.