Skip to content

Commit

Permalink
wlcore: check ssid length against the correct element
Browse files Browse the repository at this point in the history
commit 587cc28 ("wlcore: compare ssid_len before comparing
ssids") introduced a new bug - the ssid length from the
request struct was compared against the ssid length of
another request, instead the one of the cmd.

This might cause the sched scan request to fail
(with -EINVAL) in many cases.

Signed-off-by: Eliad Peller <eliad@wizery.com>
  • Loading branch information
Eliad Peller authored and John W. Linville committed Jul 10, 2012
1 parent 0fc1d2e commit faae5aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/ti/wlcore/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl,

for (j = 0; j < cmd->n_ssids; j++)
if ((req->ssids[i].ssid_len ==
req->ssids[j].ssid_len) &&
cmd->ssids[j].len) &&
!memcmp(req->ssids[i].ssid,
cmd->ssids[j].ssid,
req->ssids[i].ssid_len)) {
Expand Down

0 comments on commit faae5aa

Please sign in to comment.