Skip to content

Commit

Permalink
netlink: Deletion of an unnecessary check before the function call "_…
Browse files Browse the repository at this point in the history
…_module_get"

The __module_get() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Markus Elfring authored and David S. Miller committed Nov 19, 2014
1 parent ef87c5d commit fcd4d35
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/netlink/af_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ int netlink_add_tap(struct netlink_tap *nt)
list_add_rcu(&nt->list, &netlink_tap_all);
spin_unlock(&netlink_tap_lock);

if (nt->module)
__module_get(nt->module);
__module_get(nt->module);

return 0;
}
Expand Down

0 comments on commit fcd4d35

Please sign in to comment.