Skip to content

Commit

Permalink
goldfish: off by one in goldfish_tty_console_setup()
Browse files Browse the repository at this point in the history
The goldfish_ttys[] array has "goldfish_tty_line_count" number of
elements.  It's allocated in goldfish_tty_create_driver().  This test
should be >= instead of >.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Nov 6, 2014
1 parent a4dc923 commit fda2b41
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/goldfish.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ static struct tty_driver *goldfish_tty_console_device(struct console *c,

static int goldfish_tty_console_setup(struct console *co, char *options)
{
if ((unsigned)co->index > goldfish_tty_line_count)
if ((unsigned)co->index >= goldfish_tty_line_count)
return -ENODEV;
if (!goldfish_ttys[co->index].base)
return -ENODEV;
Expand Down

0 comments on commit fda2b41

Please sign in to comment.