Skip to content

Possibility to change landing page using WILSON_LANDING_PAGE #12

Merged
merged 4 commits into from Sep 5, 2019

Conversation

jenzopr
Copy link
Member

@jenzopr jenzopr commented Sep 4, 2019

See below.
I might have used Code -> Re-indent lines in between, that's why many indentations changed ;-)

Copy link
Contributor

@HendrikSchultheis HendrikSchultheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but one thing I noticed is that if the landing page is set to an unknown parameter the site will show all the plots on one page a bit weird but negligible. Also just so you are aware it does not make sense to set any of the plots as landing page as it will not receive any data until the feature selector is opened. Nonetheless nice addition to the app! 👍

@jenzopr
Copy link
Member Author

jenzopr commented Sep 5, 2019

Thanks for the comment, Hendrik. I will make only introduction and feature_selection valid values for the landing page selection.

@jenzopr jenzopr merged commit 89e1f3c into master Sep 5, 2019
@jenzopr jenzopr deleted the landing_page branch September 5, 2019 09:45
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants