Update LightDM from 1.28.0 to 1.30.0 and improve service unit #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without specifying the ordering in regards to `startup-tags.service` it is not guaranteed, that `/node/tags/` has been populated yet, and we have observed a non-starting LightDM on desktop systems in practice. So, order the service unit correctly.
From manual page systemd.exec(5): > StandardOutput= > Controls where file descriptor 1 (STDOUT) of the executed processes is > connected to. Takes one of inherit, null, tty, journal, syslog, kmsg, > journal+console, syslog+console, kmsg+console, file:path, append:path, socket > or fd:name. > > […] > > syslog connects standard output to the syslog(3) system syslog service, in > addition to the journal. Note that the journal daemon is usually configured to > forward everything it receives to syslog anyway, in which case this option is > no different from journal. So remove the configuration.
Do it [as Debian does it] (https://github.com/canonical/lightdm/blob/ff1c38c0616b3df66a5002ed7f531d53f218dfab/debian/lightdm.service). From manual page systemd.service(5): > BusName= > Takes a D-Bus bus name that this service is reachable as. This option is > mandatory for services where Type= is set to dbus.
pmenzel
force-pushed
the
update-lightdm-from-1.28.0-to-1.30.0
branch
from
3aa9b8d
to
24bbe14
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on hypnotoad.