Skip to content
Jump to bottom

Update LightDM from 1.28.0 to 1.30.0 and improve service unit #1692

Merged
merged 5 commits into from
Feb 12, 2020
Merged

Update LightDM from 1.28.0 to 1.30.0 and improve service unit #1692

merged 5 commits into from
Feb 12, 2020

Commits on Feb 11, 2020

  1. lightdm: Update version from 1.28.0 to 1.30.0 

    https://github.com/canonical/lightdm/releases/tag/1.30.0
    @pmenzel
    pmenzel committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    4eb8049 View commit details
    Browse the repository at this point in the history

  2. lightdm: Order service correctly after startup-tags.service 

    Without specifying the ordering in regards to `startup-tags.service` it
is not guaranteed, that `/node/tags/` has been populated yet, and we
have observed a non-starting LightDM on desktop systems in practice. So,
order the service unit correctly.
    @pmenzel
    pmenzel committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    4f0ce8e View commit details
    Browse the repository at this point in the history

  3. lightdm: Remove StandardOutput= configuration from service unit 

    From manual page systemd.exec(5):

> StandardOutput=
>     Controls where file descriptor 1 (STDOUT) of the executed processes is
>     connected to. Takes one of inherit, null, tty, journal, syslog, kmsg,
>     journal+console, syslog+console, kmsg+console, file:path, append:path, socket
>     or fd:name.
>
> […]
>
>     syslog connects standard output to the syslog(3) system syslog service, in
>     addition to the journal. Note that the journal daemon is usually configured to
>     forward everything it receives to syslog anyway, in which case this option is
>     no different from journal.

So remove the configuration.
    @pmenzel
    pmenzel committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    96bece1 View commit details
    Browse the repository at this point in the history

  4. lightdm: Order service unit after systemd-user-sessions.service 

    Do it [as Debian does it]
(https://github.com/canonical/lightdm/blob/ff1c38c0616b3df66a5002ed7f531d53f218dfab/debian/lightdm.service).
    @pmenzel
    pmenzel committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    2c4e1b0 View commit details
    Browse the repository at this point in the history

  5. lightdm: Specify D-Bus bus name in service unit 

    Do it [as Debian does it]
(https://github.com/canonical/lightdm/blob/ff1c38c0616b3df66a5002ed7f531d53f218dfab/debian/lightdm.service).

From manual page systemd.service(5):

> BusName=
>     Takes a D-Bus bus name that this service is reachable as. This option is
>     mandatory for services where Type= is set to dbus.
    @pmenzel
    pmenzel committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    24bbe14 View commit details
    Browse the repository at this point in the history