Skip to content

Fix up tcsh build #184

Merged
merged 4 commits into from
Nov 8, 2016
Merged

Fix up tcsh build #184

merged 4 commits into from
Nov 8, 2016

Conversation

donald
Copy link
Collaborator

@donald donald commented Nov 3, 2016

This is just a rewrite of #153 with all the background info in the commits. Left out the fix to disable ls-F color, because I'm not sure about actual problem. I guess its not to important.

@donald donald changed the title Fixup tcsh 2 Fixup tcsh build Nov 3, 2016
@donald
Copy link
Collaborator Author

donald commented Nov 3, 2016

This is just a rewrite of #153 with all the background info in the commits. Left out the fix to disable ls-F color, because I'm not sure about actual problem. I guess its not to important.

The gcc compiler optimization to replace a call of malloc followed by a
call of memset with a calloc call conflicts with tcshs own
implementation of calloc, which calls malloc and memset.

This bug is reported to and acknowledged by the maintainer (
http://mx.gw.com/pipermail/tcsh-bugs/2015-May/000930.html ) and should
be fixed in the next tcsh release.
The build script incorrectly installed the csh symlink into $BEE_BINDIR,
which is the bin directory of the "bee" command instead of into $BINDIR
which is the bin directory of the package. Usually this is the same.
This avoids a fork an a chdir.
@pmenzel pmenzel changed the title Fixup tcsh build Fix up tcsh build Nov 4, 2016
@pmenzel
Copy link
Collaborator

pmenzel commented Nov 4, 2016

unusuable to unusable in the last commit message. Besides that, I like it.

I’d wait for @thomas to comment.

PS: GitHub shows the wrong order in the tab commits.

@donald
Copy link
Collaborator Author

donald commented Nov 4, 2016

Seems to be by author date (as git log --oneline --author-date-order --reverse master..HEAD but unlike git log ignoring topology order (parents before children). May make sense for review, but I don't think so.

https://help.github.com/articles/why-are-my-commits-in-the-wrong-order/ :

If you always want to see commits in order, we recommend not using git rebase.

Due to an incompatible compiler optimization, 6.19.00-0 is unusable.
This revision contains a fix ( -fno-optimize-strlen ). See related
commit.
@pmenzel
Copy link
Collaborator

pmenzel commented Nov 4, 2016

Indeed, that was my explanation too.

I fixed the typo in the commit message, and force pushed it.

@thomas
Copy link
Collaborator

thomas commented Nov 8, 2016

Gute Loesung, Merci.

@pmenzel pmenzel merged commit 367e5f5 into master Nov 8, 2016
@donald donald deleted the fixup-tcsh-2 branch November 15, 2016 10:55
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants