clamav: fix unit test race condition #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed. Wenn die unit tests laufen, versucht `clamav-0.104.2-0/source/unit_tests/input/xor_testfile.py` den Folder `"build/unit_tests/input/clamav_hdb_scanfiles"` zu erstellen, der aber schon existiert. im xor_testfile.py:55 wir erst ein mkdir(), dann ein open/write/close gemacht, innerhalb eines try:-blocks ``` [ 0%] Decrypting test file clam-v3.rar... cd PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input && /usr/local/package/bin/python3.8 PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/xor_testfile.py --in_file PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar.xor --out_file PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar Failed to create file: PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar. Exception: [Errno 17] File exists: 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles' make[2]: *** [unit_tests/input/CMakeFiles/tgt_clam-v3.rar.dir/build.make:64: unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar] Error 1 make[2]: Leaving directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build' make[2]: Entering directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build' versus [ 0%] Decrypting test file clam-v3.rar... cd PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input && /usr/bin/python3 PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/xor_testfile.py --in_file PREFIX/buildroot/clamav/clamav-0.104.2-0/source/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar.xor --out_file PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar Created: 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build/unit_tests/input/clamav_hdb_scanfiles/clam-v3.rar' make[2]: Leaving directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build' make[1]: Entering directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build' [ 1%] Built target tgt_clam_cache_emax.tgz make[1]: Leaving directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build' make[1]: Entering directory 'PREFIX/buildroot/clamav/clamav-0.104.2-0/build' [ 2%] Built target tgt_clam-v3.rar ```
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wenn die unit tests laufen, versucht
clamav-0.104.2-0/source/unit_tests/input/xor_testfile.pyden Folder
"build/unit_tests/input/clamav_hdb_scanfiles"zu erstellen, der aber schon existiert.im xor_testfile.py:55 wir erst ein mkdir(), dann ein open/write/close gemacht, innerhalb eines try:-blocks