Skip to content

Update Go from gccgo 1.4.2 to upstream Go 1.9.2 #528

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Update Go from gccgo 1.4.2 to upstream Go 1.9.2 #528

merged 2 commits into from
Nov 13, 2017

Conversation

david
Copy link
Collaborator

@david david commented Nov 13, 2017

tested on machmal
bee update gcc-5.3.0-1.x86_64 # remove /usr/bin/go{,fmt}
bee install go

convert to versionless bee-file
Copy link
Collaborator

@pmenzel pmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GCC change should have been two commits. (Leave it like this now.)

How did you fix the delay when running go?

go.be0 Outdated
mee_build() {
export GOROOT_BOOTSTRAP=${PREFIX} \
GOROOT_FINAL=${LIBDIR}/go-${PKGVERSION}
cd ${S}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be removed, if you enable build_in_sourcedir at the top?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das build script erwartet, dass du in dem src dir sitzt. dadurch muss man das cd machen

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo ${S} returns /dev/shm/bee-pmenzel/go/go-1.9.2-0/source/src, so Bee takes care of everything, if you enable build_in_sourcedir (and append src, as you already did).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but when you start the build script, your working directory must be ${S}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok is fixed

go.be0 Outdated
export GOROOT_BOOTSTRAP=${PREFIX} \
GOROOT_FINAL=${LIBDIR}/go-${PKGVERSION}
cd ${S}
start_cmd ./make.bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run in parallel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't test it, because the build is very fast

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I takes over three minutes on orpheus.

go.be0 Outdated

start_cmd mkdir -p ${D}${LIBDIR}/go-${PKGVERSION}/src
for i in $LIBS; do
start_cmd cp -r ${S}/${i} ${D}${LIBDIR}/go-${PKGVERSION}/src
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent with four spaces.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@david
Copy link
Collaborator Author

david commented Nov 13, 2017

go needs his packages as source and compiled.
With go install buildmode=shared std go has compiled his standard packages

@david david force-pushed the update-go branch 2 times, most recently from a4f29ef to 350355a Compare November 13, 2017 12:03
request from niclas
helpdesk Go Update 08.11.17
@pmenzel pmenzel changed the title Update go Update Go from gccgo 1.4.2 to upstream Go 1.9.2 Nov 13, 2017
@pmenzel pmenzel merged commit 936bcdc into master Nov 13, 2017
@donald donald deleted the update-go branch December 1, 2017 15:30
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants