-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
@@ -2,25 +2,26 @@ | |||
|
|||
#export BEE_TMP_TMPDIR=/dev/shm BEE_TMP_BUILDROOT=/dev/shm/bee-root BEE_MAKEFLAGS='-j80' | |||
|
|||
# BEE_VERSION firefox-47.0.1-1 | |||
#BEE_VERSION firefox-47.0.1-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the space in the front for consistency.
> git grep BEE_VERSION
atom.be0:# BEE_VERSION atom-1.8.0-0
autofs.be0:# BEE_VERSION autofs-5.1.2-0
bash-completion.be0:# BEE_VERSION bash-completion-2.3-3
bluefish.be0:# BEE_VERSION bluefish-2.2.9-0
clang.be0:# BEE_VERSION clang-3.8.1-0
firefox.be0:# BEE_VERSION firefox-47.0.1-1
firefox_esr.be0:# BEE_VERSION firefox_esr-45.2.0-0
font-symbola.be0:# BEE_VERSION font-symbola-9.00-0
font-wqy-zenhei-0.be0:# BEE_VERSION font-wqy-zenhei-0.9.45-0
gvfs.be0:# BEE_VERSION gvfs-1.24.0-2
julia.be0:# BEE_VERSION julia-0.4.6-0
lftp.be0:# BEE_VERSION lftp-4.7.3-0
llvm.be0:# BEE_VERSION llvm-3.8.1-0
lua.be0:# BEE_VERSION lua-5.3.3-0
mxq.be0:# BEE_VERSION mxq-0.24.0-0
slock.be0:# BEE_VERSION slock-1.3-0
thunderbird.be0:# BEE_VERSION thunderbird-45.2.0-0
Some minor comments regarding the commit message. I’d use something like below.
Also, any idea, why the explicit removal is needed? Does the configure option not do what it is supposed to do? |
Hmm. Why do I get a build error "Could not find autoconf 2.13" ? I wanted to test, whether --disable-developers-tools does the same. (And to make it really beautiful, at the end we'd need to make it into a single commit with a nice "firefox: " commit message) |
yes mozilla has problems with autoconf-2.5 and so they support only autoconf-2.13 |
https://bugzilla.mozilla.org/show_bug.cgi?id=104642 |
yes but the older versions can be build with newer autoconf (eg ff-43) |
/usr/lib/firefox-devel-47.0.1 removed. There are Firefox Development-Tools.I think, we dont need this directory. This is 1GB. There is a switch "--disable-developer-tools" but unfortunately the directory is still there.
50c86f6
to
9e9c4d0
Compare
I addressed the issues and squashed the commits. |
@david, thank you! |
I might have an installable autoconf-2.13 in #69 |
/usr/lib/firefox-devel-47.0.1 removed. There are Firefox
Development-Tools.I think, we dont need this directory.
This is 1GB.