Skip to content

tcsh: Update to version 6.19.00, csh is now a symlink to tcsh #83

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

thomas
Copy link
Collaborator

@thomas thomas commented Aug 3, 2016

No description provided.

mee_install() {
bee_install
( cd "${D}"/"${BEE_BINDIR}"; ln -sv tcsh csh )
( cd "${D}"/"${MANDIR}/man1"; ln -sv tcsh.1 csh.1 )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put it into mee_install_post?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not symlink via ln -sv tcsh ${D}${BINDIR}/csh ? no subshell, no cd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a matter of personal preference. Is the csh link part of the installation or not?
Is install_post for fixups of the build or for fixups belonging to mariux?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'why not symlink...':
requires more brain, I'm never shure if your proposal is 'amd'-proof. The subshell way seems to me bullet-proof.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a matter of personal preference. Is the csh link part of the installation or not?
Is install_post for fixups of the build or for fixups belonging to mariux?

It is indeed a matter of taste. I prefer mee_install_post as you do not have to repeat the bee_install line then.

@donald
Copy link
Collaborator

donald commented Aug 16, 2016

I'd prefer mee_install_post (although, until now, I wasn't aware it existed) and ln -s tcsh "$D$BINDIR/csh".

On the other hand, there is more than one way to do it and the other variants produce the same result. So to me they are valid, too, and could have been merged as well. We can try to home in on a common style, but this shouldn't be a blocker for an update.

@thomas thomas merged commit 9f9484b into master Sep 27, 2016
@donald donald deleted the update-tcsh branch October 7, 2016 10:56
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants