Skip to content

Fix make build for 4.2.1 release #852

Merged
merged 4 commits into from Aug 2, 2018
Merged

Conversation

thomas
Copy link
Collaborator

@thomas thomas commented Jul 30, 2018

closes #849.

@pmenzel
Copy link
Collaborator

pmenzel commented Jul 30, 2018

  1. The commit messages miss the motivation for the changes.
  2. Commit “1” and “3” should be squashed together.
  3. s/build-id/revision/
  4. The patch commit should have a note, where you got the patches from.

@thomas
Copy link
Collaborator Author

thomas commented Jul 30, 2018

The overall motivation is to close an issue (#849).

  1. The messages describe whats done.
  2. Is again a matter of taste, so I read it as 'could also'
  3. revisions are also an identifier or?
  4. Yep this one I've missed, but the reference to slackware can be found here: Update GNU Make from 4.1 to 4.2.1 #769 (comment)

@wwwutz wwwutz merged commit 880ed54 into master Aug 2, 2018
@donald donald deleted the fix-make-build-for-4.2.1-release branch September 14, 2018 08:45
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux 4.14.55 build fails with installed developer version of make
3 participants