Skip to content

Commit

Permalink
beesh: Abort if download fails
Browse files Browse the repository at this point in the history
Currently, bee doesn't detect the situation when a partial file is
downloaded. An incomplete archive usually makes the following extract to
fail, but the broken file is kept in the cache an needs to be removed
manually. The situation, when a failed download produces an empty file,
is already handled. Empty cache files are removed when bee is run the
next time.

Currently, bee contains explicit code to ignore errors from wget. This
code existed in the initial commit 067ccf2 ("initial revision") from
2010. The reasoning is unclear today and has to be rediscovered if it's
still valid. So this patch is kind of experimental and might need
to be undone.

Remove code to explicitly ignore wget failures. As the script is running
with `-e`, a wget failure should invoke the EXIT trap, which removes the
incomplete file. This is untested.
  • Loading branch information
donald committed Sep 11, 2023
1 parent 7d4d2bc commit 178e146
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/beesh.sh.in
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ function fetch_one_file() {
--no-clobber \
--timeout=60 \
--tries=1 \
"${url}" || true
"${url}"

trap - EXIT

Expand Down

0 comments on commit 178e146

Please sign in to comment.