Add two additional format placeholders for beeversion #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:-) |
pmenzel
force-pushed
the
add-two-more-placeholders-for-beeversion
branch
from
6368d91
to
e2c111f
Compare
|
I amended the commit description. |
:-) |
pmenzel
force-pushed
the
add-two-more-placeholders-for-beeversion
branch
from
e2c111f
to
9f23bb5
Compare
Add *E* and *d* as placeholders to format the extra version. Sometimes, the bee version requirement, to separate the extra version with an underscore, contradicts the upstream versioning, which for example uses a dash. 4.8-rc2 is the version of the second release candidate of the Linux kernel 4.8. An underscore has to be used in the bee file version though. ``` $ beeversion linux-4.8_rc2-95.x86_64 PKGNAME=linux PKGEXTRANAME= PKGEXTRANAME_UNDERSCORE= PKGEXTRANAME_DASH= PKGVERSION=( 4.8 4 4.8 ) PKGEXTRAVERSION=rc2 PKGEXTRAVERSION_UNDERSCORE=_rc2 PKGEXTRAVERSION_DASH=-rc2 PKGREVISION=95 PKGARCH=x86_64 PKGFULLNAME=linux PKGFULLVERSION=4.8_rc2 PKGFULLPKG=linux-4.8_rc2-95 PKGALLPKG=linux-4.8_rc2-95.x86_64 PKGSUFFIX= ``` As can be seen, environment variables to output the extra version with a dash (-) or with an underscore (_) are provided. These options are missing as placeholders for the switch `format`. So, add them. *E* adds an underscore in front of the extra version, while *d* adds a dash. These are useful, as now, no additional logic has to be implemented in scripts calling `beeversion`, to check if an extra version is present, to determine if a separator needs to be added or not. In case of the Linux kernel, 4.8-rc2 can be created with the switch below. ``` > beeversion --format="%v%d" linux-4.8_rc2-95.x86_64 4.8-rc2 ```
pmenzel
force-pushed
the
add-two-more-placeholders-for-beeversion
branch
from
9f23bb5
to
8358f85
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.