beesh: Force defined mode for copies of source files #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bee source file and the package source and patch files are copied into the bee package, the bee archive directory and into the build archive with `cp`. The modes of the source files are more or less undefined. Most notably this is true for the bee source files themself, because git doesn't store all file permissions in the repository, just the "x" bit. Add `--no-preserve=mode` option to `cp` so that the undefined modes are not inherited. The umask of the processes running bee is already defined to 022.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bee source file and the package source and patch files
are copied into the bee package, the bee archive directory and into
the build archive with
cp.The modes of the source files are more or less undefined. Most notably
this is true for the bee source files themself, because git doesn't store
all file permissions in the repository, just the "x" bit.
Add
--no-preserve=modeoption tocpso that the undefined modes arenot inherited. The umask of the processes running bee is already
defined to 022.