Support Meson build system #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also submitted upstream. I’d prefer to discuss it there. |
|
Update this to match upstream? |
[Description][2]: > Meson is an open source build system meant to be both extremely fast, > and, even more importantly, as user friendly as possible. > > The main design point of Meson is that every moment a developer spends > writing or debugging build definitions is a second wasted. So is every > second spent waiting for the build system to actually start compiling > code. [1]: http://mesonbuild.com/Quick-guide.html [2]: http://mesonbuild.com/
If the Meson executable is not found, an error will be thrown by the shell, so the check is not needed. Additionally, the environment could be changed in the bee file, so deterministically continue.
pmenzel
force-pushed
the
support-meson-build-system
branch
from
d09a429
to
3f7924c
Compare
|
Am 15.01.2018 um 16:55 schrieb Donald Buczek:
Update this to match [upstream](https://github.com/bee/bee/pull/214)?
Done.
|
The function `start_cmd()` in the bee shell runs "{@}" causing the
setting of the environment variable to be executed, which is of course
not found.
```
function start_cmd() {
print_info "${COLOR_CYAN}${@}"
"${@}"
}
```
Work around it, by setting the environment variable `DESTDIR` outside.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MarIuX, make sure to have
mesoninstalled, for example, by doing. /pkg/python-3.6.4-0/profile.