-
Notifications
You must be signed in to change notification settings - Fork 2
beesh.sh: use pbzip2 for saving build environment when available #23
beesh.sh: use pbzip2 for saving build environment when available #23
Conversation
src/beesh.sh.in
Outdated
@@ -683,7 +683,7 @@ function bee_archivebuild() { | |||
B=${BEEWORKDIR}/build | |||
fi | |||
|
|||
tar -cjf ${archive} \ | |||
tar -cf ${archive} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use -I
to set compress program? so you do not need to store&read file which should give even more speedup..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Marius :)
Good point, IIRC a similar approach using bgzip (a parallel gzip from samtools) failed, so I went for the safe way right from the start. And to be honest, I haven't even checked if pbzip2 can be feed from stdin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-I pbzip2
does work, so I'd vote for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 6b1ee7e holds the new variant using -I
.
For the record, some tests with
|
Fine with me. I suggest, you |
6b1ee7e
to
c24f7de
Compare
Cleaned up. What are the next steps, a new bee version? Well, the present bee file says |
Yes, make a release. Stick to existing name scheme for release name and tag name. Next release will include #24 as well (for the release information). The make an update mariux64/bee-files. |
This will keep the mood down when building kernels :)