Set CMAKE_INSTALL_LIBDIR in CMake build type
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s `lib64` by default [1].
> object code libraries (lib or lib64 or lib/<multiarch-tuple> on Debian)
This conflicts with the symbolic link in MarIuX.
$ ls -ld /usr/lib*
drwxr-xr-x 240 root root 143360 Feb 11 18:44 /usr/lib
lrwxrwxrwx 1 root root 3 Mar 7 2011 /usr/lib64 -> lib
drwxr-xr-x 21 root root 4096 Feb 5 16:45 /usr/libexec
Consider the current package has `/usr/lib/pkgconfig/libzip.pc`
installed, and the newer version installs the same file into
`/usr/lib64/pkgconfig/libzip.pc`. On upgrade, when removing the file
from the old package, bee will remove `/usr/lib64/pkgconfig/libzip.pc`
because of the symbolic link, which is unwanted.
So set it to `LIBDIR`, so that the system configuration is applied.
[1]: https://cmake.org/cmake/help/v3.8/module/GNUInstallDirs.html
pmenzel
changed the title
CMAKE_INSTALL_LIBDIR in CMake built typeCMAKE_INSTALL_LIBDIR in CMake build type
|
Looks good. Please rebase to master. |
pmenzel
force-pushed
the
set-libdir-in-cmake-build-type
branch
from
1e3bc7f
to
13daff2
Compare
|
Done. |
|
Now we need a bee release and a bee update via bee-files ... sigh... überorganisiert |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.