Fix cmake build #60
Merged
Fix cmake build #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add '[' to the set of characters which need escaping when used in a regular expression.
cmake, by default, uses CMAKE_BULD_TYPE=Debug with implies '-O0'. This has a severe performance impact for most software. Let bee use CMAKE_BULD_TYPE=RelWithDebInfo by default, which implies '-O2'. For most software, the difference between '-O2' and '-O3' is neglectable. Bee packages with special performance considerations, for example zlib, might use -DCMAKE_BUILD_TYPE=Release in their bee file to force '-O3'.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to
CMAKE_BUILD_TYPE=RelWithDebInfo(-O2) with cmake instead ofCMAKE_BUILD_TYPE=Debug(-O0).Also add a minor fix for filenames which include the character
[like/usr/bin/[.See https://github.molgen.mpg.de/mariux64/mariux64-issues/issues/95