Implement versionless bee files #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -763,9 +763,7 @@ function verify_new_package_variables() { | |||
| fi | |||
| fi | |||
| PKGFULLVERSION="${PKGVERSION}${PKGEXTRAVERSION:+_${PKGEXTRAVERSION}}" | |||
| } | |||
There was a problem hiding this comment.
Sorry, it is. Please ignore.
|
Looks good to me. I didn’t test it though. Is there a place to document these changes? That means, give an example how to use the new feature? If there is no such place, the merge request description could be used. |
…kage_variables we want to expand the handling of variables changed by the beefile a bit which is easier implement and follow when done in a single function
When we start with a versionless file, we need to be able to change the versions. We will add other tests for completeness in the following patches
we allow the bee file to be started without a complete version set. the bee file should set the version with a callback we add in a following patch. When we allow the version to be set in the bee file, $B and $S, which depend on the full package name, can only be set after the bee file is run. So we need to postpone the effect of the build_in_sourcedir callback to a later time. The beefiles can also set $B=$S directly. We deprecate this with this patch, but still detect it and act accordinly.
at the same time add utility function bee_die and relax the checks so that we can update the full version string from inside the bee file
this is save, because after every call the completeness of the output is checked and a wrong syntax will be detected
we may fail to find a free revision number (eg with versionless bee files) and if so, we want to avoid the error message of beeversion and a wrong "cp" hint.
|
I've put a very short description into the wiki https://github.molgen.mpg.de/mariux64/bee/wiki |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.