Skip to content

Commit

Permalink
rtc: tps6594: Fix integer overflow on 32bit systems
Browse files Browse the repository at this point in the history
The problem is this multiply in tps6594_rtc_set_offset()

	tmp = offset * TICKS_PER_HOUR;

The "tmp" variable is an s64 but "offset" is a long in the
(-277774)-277774 range.  On 32bit systems a long can hold numbers up to
approximately two billion.  The number of TICKS_PER_HOUR is really large,
(32768 * 3600) or roughly a hundred million.  When you start multiplying
by a hundred million it doesn't take long to overflow the two billion
mark.

Probably the safest way to fix this is to change the type of
TICKS_PER_HOUR to long long because it's such a large number.

Fixes: 9f67c1e ("rtc: tps6594: Add driver for TPS6594 RTC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/1074175e-5ecb-4e3d-b721-347d794caa90@stanley.mountain
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  • Loading branch information
Dan Carpenter authored and Alexandre Belloni committed Jan 12, 2025
1 parent 8c28c49 commit 09c4a61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/rtc/rtc-tps6594.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#define MAX_OFFSET (277774)

// Number of ticks per hour
#define TICKS_PER_HOUR (32768 * 3600)
#define TICKS_PER_HOUR (32768 * 3600LL)

// Multiplier for ppb conversions
#define PPB_MULT NANO
Expand Down

0 comments on commit 09c4a61

Please sign in to comment.