Skip to content

Commit

Permalink
sched/wait: Collapse __wait_event_interruptible_tty()
Browse files Browse the repository at this point in the history
Reduce macro complexity by using the new ___wait_event() helper.
No change in behaviour, identical generated code.

Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20131002092528.831085521@infradead.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Oct 4, 2013
1 parent a1dc685 commit 0d1e1c8
Showing 1 changed file with 4 additions and 17 deletions.
21 changes: 4 additions & 17 deletions include/linux/tty.h
Original file line number Diff line number Diff line change
Expand Up @@ -679,23 +679,10 @@ static inline void tty_wait_until_sent_from_close(struct tty_struct *tty,
})

#define __wait_event_interruptible_tty(tty, wq, condition, ret) \
do { \
DEFINE_WAIT(__wait); \
\
for (;;) { \
prepare_to_wait(&wq, &__wait, TASK_INTERRUPTIBLE); \
if (condition) \
break; \
if (signal_pending(current)) { \
ret = -ERESTARTSYS; \
break; \
} \
tty_unlock(tty); \
schedule(); \
tty_lock(tty); \
} \
finish_wait(&wq, &__wait); \
} while (0)
___wait_event(wq, condition, TASK_INTERRUPTIBLE, 0, ret, \
tty_unlock(tty); \
schedule(); \
tty_lock(tty))

#ifdef CONFIG_PROC_FS
extern void proc_tty_register_driver(struct tty_driver *);
Expand Down

0 comments on commit 0d1e1c8

Please sign in to comment.