Skip to content

Commit

Permalink
net/atm/mpc: Avoid open-coded assignment of timer callback function
Browse files Browse the repository at this point in the history
Instead of a single function assignment, just fold this into DEFINE_TIMER().

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Kees Cook <keescook@chromium.org>
  • Loading branch information
Kees Cook committed Nov 21, 2017
1 parent 2ea5b4d commit 1e9aa74
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/atm/mpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ static struct notifier_block mpoa_notifier = {

struct mpoa_client *mpcs = NULL; /* FIXME */
static struct atm_mpoa_qos *qos_head = NULL;
static DEFINE_TIMER(mpc_timer, NULL);
static DEFINE_TIMER(mpc_timer, mpc_cache_check);


static struct mpoa_client *find_mpc_by_itfnum(int itf)
Expand Down Expand Up @@ -1413,7 +1413,6 @@ static void mpc_timer_refresh(void)
{
mpc_timer.expires = jiffies + (MPC_P2 * HZ);
checking_time = mpc_timer.expires;
mpc_timer.function = (TIMER_FUNC_TYPE)mpc_cache_check;
add_timer(&mpc_timer);
}

Expand Down

0 comments on commit 1e9aa74

Please sign in to comment.