Skip to content

Commit

Permalink
rxrpc: Remove RXRPC_CALL_PROC_BUSY
Browse files Browse the repository at this point in the history
Remove RXRPC_CALL_PROC_BUSY as work queue items are now 100% non-reentrant.

Signed-off-by: David Howells <dhowells@redhat.com>
  • Loading branch information
David Howells committed Aug 23, 2016
1 parent a01512d commit 26164e7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion net/rxrpc/ar-internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ enum rxrpc_call_flag {
RXRPC_CALL_RCVD_LAST, /* all packets received */
RXRPC_CALL_RUN_RTIMER, /* Tx resend timer started */
RXRPC_CALL_TX_SOFT_ACK, /* sent some soft ACKs */
RXRPC_CALL_PROC_BUSY, /* the processor is busy */
RXRPC_CALL_INIT_ACCEPT, /* acceptance was initiated */
RXRPC_CALL_HAS_USERID, /* has a user ID attached */
RXRPC_CALL_EXPECT_OOS, /* expect out of sequence packets */
Expand Down
6 changes: 0 additions & 6 deletions net/rxrpc/call_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -832,11 +832,6 @@ void rxrpc_process_call(struct work_struct *work)
call->debug_id, rxrpc_call_states[call->state], call->events,
(jiffies - call->creation_jif) / (HZ / 10));

if (test_and_set_bit(RXRPC_CALL_PROC_BUSY, &call->flags)) {
_debug("XXXXXXXXXXXXX RUNNING ON MULTIPLE CPUS XXXXXXXXXXXXX");
return;
}

if (!call->conn)
goto skip_msg_init;

Expand Down Expand Up @@ -1281,7 +1276,6 @@ void rxrpc_process_call(struct work_struct *work)
}

error:
clear_bit(RXRPC_CALL_PROC_BUSY, &call->flags);
kfree(acks);

/* because we don't want two CPUs both processing the work item for one
Expand Down

0 comments on commit 26164e7

Please sign in to comment.